Use MongoDB fields projection on update to reduce the memory footpints #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the discussion in another issue balderdashy/waterline#805, I would suggest for an update operation, it's not needed to return the full updated result set. But even it's for compatibility reason we keep it, it should have an option to turn it of. At lease, if nothing will change please use MongoDB projection when only fetching the needed `_id` field
Fix failed travis test
particlebanana
added a commit
that referenced
this pull request
Jan 25, 2016
Use MongoDB fields projection on update to reduce the memory footpints
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the discussion in another issue balderdashy/waterline#805, I would suggest for an update operation, it's not needed to return the full updated result set. But even it's for compatibility reason we keep it, it should have an option to turn it off. At lease, if for now there's no plan to do it, we can use MongoDB projection when only fetching the needed
_idfield in the first find query