allow searching including newlines #308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a match any character set ([\s\S] instead of .) to fix 'contains', 'like', 'startsWith', and 'endsWith' queries to work with multi-line strings.
|
@particlebanana mind taking a peek? It's short. Are multiline string matches considered a luxury of mongo or should other adapters support this as well? In that case, a test would be great to accompany this. |
This was referenced Jan 25, 2016
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a match any character set ([\s\S] instead of .) to fix 'contains', 'like', 'startsWith', and 'endsWith' queries to work with multi-line strings.
This is a different way of solving the problem of #220 and #221, and it was recommended by @andyhu as a better way of solving the problem than adding the
mflag, which breaksstartsWithandendsWith.My specific use case is similar to the HTML one - I want to search across a string of markdown that has newlines in it.