Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update dependencies #7348

Merged
merged 8 commits into from
Sep 17, 2024
Merged

Update dependencies #7348

merged 8 commits into from
Sep 17, 2024

Conversation

eashaw
Copy link
Member

@eashaw eashaw commented Sep 12, 2024

Changes:

  • Upgraded dependencies:
    • express: 4.19.2 » 4.21.0
    • serve-static: 1.13.1 » 1.16.2
    • skipper: 0.9.4 » 0.9.5
    • router@1.3.2 » @sailshq/router@1.3.9

@sailsbot
Copy link

Thanks for submitting this pull request, @eashaw! We'll look at it ASAP.

In the mean time, here are some ways you can help speed things along:

  • discuss this pull request with other contributors and get their feedback. (Reactions and comments can help us make better decisions, anticipate compatibility problems, and prevent bugs.)
  • ask another JavaScript developer to review the files changed in this pull request. (Peer reviews definitely don't guarantee perfection, but they help catch mistakes and enourage collaborative thinking. Code reviews are so useful that some open source projects require a minimum number of reviews before even considering a merge!)
  • if appropriate, ask your business to sponsor your pull request. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
  • make sure you've answered the "why?" (Before we can review and merge a pull request, we feel it is important to fully understand the use case: the human reason these changes are important for you, your team, or your organization.)

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

Copy link

socket-security bot commented Sep 12, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/express@4.21.0 environment, filesystem, network Transitive: eval, unsafe +60 2.11 MB wesleytodd
npm/serve-static@1.16.2 Transitive: environment, eval, filesystem, network, unsafe +18 312 kB wesleytodd

🚮 Removed packages: npm/express@4.19.2, npm/router@1.3.2, npm/serve-static@1.13.1

View full report↗︎

@eashaw eashaw marked this pull request as draft September 13, 2024 15:11
@eashaw eashaw marked this pull request as ready for review September 16, 2024 18:20
@eashaw eashaw merged commit 2fe3a50 into master Sep 17, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants