Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed solution for #26. The setVolume() method sets the volume always but still caches the saved value.
I wanted to get rid that
curvol
cache value, the returned value could be read from the chip directly, but it needs to be converted back (by amap
function for example) to a range from 0 to 100. There was a side effect, when I did a small test like:then the
readBack
variable was set to 69. Probably this is an effect of rounding when usingmap
method. I gave up with this solution, so in my PR thecurvol
is not totaly removed.