Call device update hook when target OS release changes #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows Supervisors that support Supervisor-managed OS upgrades to trigger a HUP. See: https://balena.fibery.io/Work/Improvement/API-and-SDK-changes-for-supervisor-hostOS-updates-2348 Change-type: minor Signed-off-by: Christina Ying Wang <christina@balena.io>
Page-
reviewed
Dec 6, 2024
| if ( | ||
| (request.values.is_pinned_on__release !== undefined || | ||
| request.values.belongs_to__application != null || | ||
| request.values.device_name != null) && | ||
| request.values.device_name != null || |
There was a problem hiding this comment.
I thought the supervisor only updated the device name for containers when they were receiving other updates? In which case there's no point to trigger a supervisor update check in that case as it would just be unnecessary load
There was a problem hiding this comment.
The Supervisor stores the most up-to-date device name in its config table of its sqlite database though, and uses this for SV API's /v2/device/name calls. You're right though that BALENA_DEVICE_NAME_AT_INIT env var for services only changes when starting up the service, and changing the name doesn't result in a service restart by itself.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Supervisors that support Supervisor-managed OS upgrades to trigger a HUP.
See: https://balena.fibery.io/Work/Improvement/API-and-SDK-changes-for-supervisor-hostOS-updates-2348
Change-type: minor