Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Migrate filepath to jballerina #15914

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Conversation

riyafa
Copy link
Contributor

@riyafa riyafa commented Jun 21, 2019

Purpose

Migrate filepath to jballerina

Approach

Migrate according to the practice.

Samples

N/A

Remarks

N/A

Check List

  • Read the Contributing Guide
  • Required Balo version update
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@riyafa riyafa requested a review from daneshk June 21, 2019 08:28
@riyafa riyafa added the Team/StandardLibs All Ballerina standard libraries label Jun 21, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (jballerina@93962c0). Click here to learn what that means.
The diff coverage is 56.25%.

Impacted file tree graph

@@              Coverage Diff              @@
##             jballerina   #15914   +/-   ##
=============================================
  Coverage              ?   19.11%           
  Complexity            ?     4843           
=============================================
  Files                 ?     1491           
  Lines                 ?    75384           
  Branches              ?     9870           
=============================================
  Hits                  ?    14411           
  Misses                ?    59250           
  Partials              ?     1723
Impacted Files Coverage Δ Complexity Δ
...erinalang/stdlib/filepath/nativeimpl/Absolute.java 33.33% <33.33%> (ø) 1 <0> (?)
...lerinalang/stdlib/filepath/nativeimpl/Matches.java 50% <50%> (ø) 1 <0> (?)
...lerinalang/stdlib/filepath/nativeimpl/Resolve.java 60% <60%> (ø) 1 <0> (?)
.../java/org/ballerinalang/stdlib/filepath/Utils.java 72.72% <75%> (ø) 5 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93962c0...6b6ccdb. Read the comment docs.

@riyafa riyafa merged commit 8ee14d4 into ballerina-platform:jballerina Jun 24, 2019
@riyafa riyafa deleted the file branch September 7, 2019 04:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Team/StandardLibs All Ballerina standard libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants