Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Revert "Change the ballerina command to jballerina in vscode extension" #16205

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Revert "Change the ballerina command to jballerina in vscode extension" #16205

merged 1 commit into from
Jul 17, 2019

Conversation

pahans
Copy link
Contributor

@pahans pahans commented Jul 3, 2019

Reverts #15958

@pahans pahans requested review from hevayo and nadeeshaan and removed request for hevayo July 3, 2019 08:07
@codecov-io
Copy link

codecov-io commented Jul 3, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (jballerina@fed58b3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             jballerina   #16205   +/-   ##
=============================================
  Coverage              ?   15.35%           
  Complexity            ?     3517           
=============================================
  Files                 ?     1477           
  Lines                 ?    71494           
  Branches              ?     8573           
=============================================
  Hits                  ?    10980           
  Misses                ?    59529           
  Partials              ?      985

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fed58b3...81be105. Read the comment docs.

@shafreenAnfar
Copy link
Contributor

Closing this as it requires few other changes.

@pahans pahans reopened this Jul 16, 2019
@pahans pahans mentioned this pull request Jul 16, 2019
Merged
14 tasks
nadeeshaan
nadeeshaan approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@nadeeshaan nadeeshaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@pahans pahans changed the base branch from jballerina to master July 16, 2019 15:38
@anupama-pathirage anupama-pathirage added the Team/CompilerFETools Semantic API, Formatter, Shell label Jul 17, 2019
@pahans pahans merged commit 49f8663 into master Jul 17, 2019
@pahans pahans deleted the revert-15958-change-ballerina-command2 branch July 17, 2019 06:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@NipunaRanasinghe NipunaRanasinghe NipunaRanasinghe approved these changes

@nadeeshaan nadeeshaan nadeeshaan approved these changes

@hevayo hevayo Awaiting requested review from hevayo

Assignees
No one assigned
Labels
Team/CompilerFETools Semantic API, Formatter, Shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pahans @codecov-io @shafreenAnfar @nadeeshaan @NipunaRanasinghe @anupama-pathirage