Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Pick Module.md as the default doc for v2 balas #43642

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

azinneera
Copy link
Contributor

@azinneera azinneera commented Nov 22, 2024

Purpose

Pick Module.md as the default doc for v2 balas

Fixes #42981

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 63.15789% with 14 lines in your changes missing coverage. Please review.

Project coverage is 77.46%. Comparing base (4330bae) to head (782e026).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...java/io/ballerina/projects/internal/BalaFiles.java 50.00% 12 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #43642      +/-   ##
============================================
- Coverage     77.47%   77.46%   -0.02%     
- Complexity    58515    58517       +2     
============================================
  Files          3434     3434              
  Lines        218698   218733      +35     
  Branches      28919    28923       +4     
============================================
+ Hits         169441   169442       +1     
- Misses        39858    39893      +35     
+ Partials       9399     9398       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@gimantha
Copy link
Contributor

@azinneera Shall we prioritise this PR to merge or close?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Add README.md as the primary documentation file for library packages
3 participants