Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update README.md #43722

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GamiXChanuka
Copy link

@GamiXChanuka GamiXChanuka commented Dec 24, 2024

Grammar errors corrected.

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Grammar errors corrected.
@CLAassistant
Copy link

CLAassistant commented Dec 24, 2024

CLA assistant check
All committers have signed the CLA.

@@ -54,7 +54,7 @@ You can use the following resources to learn Ballerina.

## Report issues and security flaws

>**Tip:** If you are unsure whether you have found a bug, search the existing issues in the GitHub repo and raise it in the [Ballerina Discord](https://discord.com/invite/wAJYFbMrG2) or [Stack Overflow](https://stackoverflow.com/questions/tagged/ballerina).
>**Tip:** If you are unsure whether you have found a bug, search the existing issues in the GitHub repo and raise them in the [Ballerina Discord](https://discord.com/invite/wAJYFbMrG2) or [Stack Overflow](https://stackoverflow.com/questions/tagged/ballerina).
Copy link
Contributor

@tharindu-nw tharindu-nw Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The it here seems to be referring to the bug the user has found. In that case, the original version is okay IMO

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, shall we leave this as is?

@tharindu-nw tharindu-nw requested a review from MaryamZi January 3, 2025 02:04
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@53f6d83). Learn more about missing BASE report.
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #43722   +/-   ##
=========================================
  Coverage          ?   77.42%           
  Complexity        ?    58620           
=========================================
  Files             ?     3445           
  Lines             ?   219172           
  Branches          ?    28968           
=========================================
  Hits              ?   169686           
  Misses            ?    40055           
  Partials          ?     9431           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants