Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix issues with Dead Code Elimination feature #124

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Conversation

TharmiganK
Copy link
Contributor

@TharmiganK TharmiganK commented Nov 6, 2024

Purpose

$Subject

Part of: ballerina-platform/ballerina-library#7339

There are no usages of ValueCreator or TypeCreator APIs. But there are usages of ErrorCreator APIs. Since the following sub types of constraint:Error are created from the native code and not referred in any of the external function return types, we need to mark them as ExternalDependency.

  1. constraint:ValidationError
  2. constraint:TypeConversionError

Examples

N/A

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

Copy link

sonarqubecloud bot commented Nov 6, 2024

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.54%. Comparing base (77de29e) to head (9c00a3f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #124      +/-   ##
============================================
+ Coverage     86.20%   89.54%   +3.33%     
- Complexity      226      315      +89     
============================================
  Files            22       38      +16     
  Lines           522      679     +157     
  Branches        104      136      +32     
============================================
+ Hits            450      608     +158     
+ Misses           51       41      -10     
- Partials         21       30       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TharmiganK TharmiganK merged commit 52ab5a8 into main Nov 6, 2024
8 checks passed
@TharmiganK TharmiganK deleted the fix-dce-errors branch November 6, 2024 10:00
TharmiganK added a commit that referenced this pull request Nov 18, 2024
[Revert] Fix issues with Dead Code Elimination feature #124
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants