Make compliment op for function types more explicit #1221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heshanpadmasiri
commented
Jul 25, 2023
heshanpadmasiri
commented
Jul 26, 2023
compiler/modules/types/function.bal
Outdated
| @@ -221,6 +221,10 @@ function bddFunctionAtomicType(Env env, Bdd bdd) returns FunctionAtomicType? { | |||
| return (); | |||
| } | |||
|
|
|||
| function functionSubtypeComplement(ProperSubtypeData t) returns SubtypeData { | |||
| return bddSubtypeDiff(FUNCTION_TOP, t); | |||
There was a problem hiding this comment.
@jclark I don't think this actually makes a difference since I can replace the FUNCTION_TOP with any arbitrary BDD node (say LIST_SUBTYPE_MAPPING_RO -> readonly & (map<readonly>)[]) and everything works. This is true for table type as well. The only test that fails is this serialization test since they produce slightly different BDDs.
Represent the function top type (`function`) explicitly as an atomic type and use that to calculate the function complement. Note that typing was even without this fix.
heshanpadmasiri
force-pushed
the
fix/function-complement
branch
2 times, most recently
from
c32f1b8 to
37b9aa9
Compare
We don't have a signature to represent the function top type. Which means we have to special case serialization of function top type.
heshanpadmasiri
force-pushed
the
fix/function-complement
branch
from
37b9aa9 to
23d4c69
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$Subject
Resolves #1220