Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Pytensor only #614

Merged
merged 5 commits into from
Dec 21, 2022
Merged

Pytensor only #614

merged 5 commits into from
Dec 21, 2022

Conversation

canyon289
Copy link
Collaborator

Thank your for opening a PR!

Before you proceed, please check the following notes.

  • Make sure you describe the changes introduced in the PR.
  • If this PR addresses an existing issue, please mention it here.
  • Check our Guidelines for Contributing.
  • In particular, pay attention to the pull request checklist.
  • The most important points are to
    • Install all the needed requirements (requirements.txt, requirements-dev.txt, etc.)
    • Make sure all test pass.
    • Make sure your code passes black.
    • Make sure your code passes pylint.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2022

Codecov Report

Merging #614 (caa3a59) into main (157cbda) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
+ Coverage   82.00%   82.19%   +0.18%     
==========================================
  Files          40       40              
  Lines        3107     3094      -13     
==========================================
- Hits         2548     2543       -5     
+ Misses        559      551       -8     
Impacted Files Coverage Δ
bambi/backend/links.py 96.15% <100.00%> (+6.49%) ⬆️
bambi/backend/pymc.py 82.32% <100.00%> (+0.90%) ⬆️
bambi/backend/terms.py 95.13% <100.00%> (+1.26%) ⬆️
bambi/backend/utils.py 90.00% <100.00%> (+13.07%) ⬆️
bambi/tests/test_built_models.py 96.20% <0.00%> (-0.30%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tomicapretto
Copy link
Collaborator

I think the CI failing is a problem with numerical precision that we have seen previously, so that's not a big issue.

But I think we should pin pymc to be at least version 5 in our requirements.txt file. Right now, it would install with PyMC 4.X.X, but that would install Aesara instead of PyTensor, and then we would have dependency issues.

@canyon289
Copy link
Collaborator Author

Good point

@tomicapretto
Copy link
Collaborator

Thanks! :D

@tomicapretto tomicapretto merged commit 99e3026 into main Dec 21, 2022
@tomicapretto tomicapretto deleted the pytensor_only branch April 18, 2023 12:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants