Update additional dependencies install command #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was starting to do some development and ran into the following: ```bash pip install .[dev] zsh: no matches found: .[dev] ``` Found that adding the single quote around it resolved it, so updated the instructions accordingly: ```bash pip install '.[dev]' ``` And similar for the jax dependencies. I assume this is ubiquitous, but if it's just a zsh for some reason, feel free to disregard.
Codecov Report
@@ Coverage Diff @@
## main #689 +/- ##
=======================================
Coverage 88.32% 88.32%
=======================================
Files 40 40
Lines 2862 2862
=======================================
Hits 2528 2528
Misses 334 334 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I was not aware of this potential issue! Thanks for fixing it. I confirm it still works on my side. |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was starting to do some development and ran into the following:
Found that adding the single quote around it resolved it, so updated the instructions accordingly:
pip install '.[dev]'And similar for the jax dependencies.
I assume this is ubiquitous, but if it's just a zsh for some reason, feel free to disregard.