Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

New ordered name #724

Merged
merged 2 commits into from
Sep 21, 2023
Merged

New ordered name #724

merged 2 commits into from
Sep 21, 2023

Conversation

tomicapretto
Copy link
Collaborator

Two things happening here

  • I'm changing the name of the univariate_ordered transform for ordered.
  • And I'm pinning numpy to < 1.26.0 to make it work with pytensor

Copy link
Collaborator

@GStechschulte GStechschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 Thanks a lot! Once PR 444 is merged, we should be able to remove the numpy < 1.26.

@tomicapretto tomicapretto merged commit 169564f into bambinos:main Sep 21, 2023
@tomicapretto tomicapretto deleted the new_ordered_name branch September 21, 2023 07:58
GStechschulte pushed a commit to GStechschulte/bambi that referenced this pull request Sep 22, 2023
* Replace univariate_ordered with ordered

* pin numpy<1.26.0
GStechschulte pushed a commit to GStechschulte/bambi that referenced this pull request Sep 22, 2023
* Replace univariate_ordered with ordered

* pin numpy<1.26.0
GStechschulte pushed a commit to GStechschulte/bambi that referenced this pull request Oct 3, 2023
* Replace univariate_ordered with ordered

* pin numpy<1.26.0
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants