feat: popover component & new topic actions layout #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview Deployment
|
mergify
bot
added
waiting-approval
mergify
bot
added
ci:test:fail
and removed
waiting-approval
mergify
bot
added
waiting-approval
trim21
reviewed
May 11, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #580 +/- ##
==========================================
+ Coverage 82.46% 82.69% +0.23%
==========================================
Files 98 100 +2
Lines 5953 6034 +81
Branches 421 424 +3
==========================================
+ Hits 4909 4990 +81
Misses 1038 1038
Partials 6 6
☔ View full report in Codecov by Sentry. |
Ayase-252
reviewed
May 12, 2023
| </> | ||
| )} | ||
| {/* TODO: 实现绝交和报告疑虑功能 */} | ||
| <Button type='text'>绝交</Button> |
There was a problem hiding this comment.
绝交是啥功能 (bgm38) （不是代码问题，纯好奇）
There was a problem hiding this comment.
|
没有登录状态下只有楼层和发帖日期是不是最后不应该有分隔的竖线 |
cokemine
approved these changes
May 14, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#112
添加 Popover 组件，按照设计稿修改小组讨论按钮，顺带把按钮封装成了组件
Popover 的测试不知道怎么搞，测试框架好像获取不到完整的 CSS 样式，试了window.getComputeStyle和toHaveStyle都不行现在 E2E 测试已经覆盖了，那就不写了吧（