Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: add change from vault-env to fix log level configurability #179

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

94DanielBrown
Copy link
Contributor

Overview

This change has been merged into vault-env and makes slog default to info and become configurable through env vars.
Tested manually and the identical change works here (had to use different env variable name to test as this has changed).

Fixes #(issue)

Notes for reviewer

@94DanielBrown 94DanielBrown requested a review from a team as a code owner June 25, 2024 08:28
@94DanielBrown 94DanielBrown requested review from ramizpolic and removed request for a team June 25, 2024 08:28
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines label Jun 25, 2024
Signed-off-by: Daniel Brown <daniel.brown2@sainsburys.co.uk>
Copy link
Member

@csatib02 csatib02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @94DanielBrown!

@csatib02 csatib02 merged commit 102b87e into bank-vaults:main Jun 25, 2024
20 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
size/XS Denotes a PR that changes 0-9 lines
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants