Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: AWS support configmap mutation #141

Merged
merged 1 commit into from
Aug 14, 2024
Merged

feat: AWS support configmap mutation #141

merged 1 commit into from
Aug 14, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Aug 8, 2024 •
edited
Loading

Overview

  • This PR enables AWS Configmap mutation.

Part of #62

@csatib02
feat: enable AWS configmap mutation
a75835f 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 csatib02 added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 8, 2024
@csatib02 csatib02 self-assigned this Aug 8, 2024
@csatib02 csatib02 requested a review from a team as a code owner August 8, 2024 12:30
@csatib02 csatib02 removed the request for review from a team August 8, 2024 12:30
@github-actions github-actions bot added the size/M Denotes a PR that changes 100-499 lines label Aug 8, 2024
@csatib02 csatib02 changed the title feat: enable AWS configmap mutation feat: AWS support configmap mutation Aug 8, 2024
akijakya
akijakya approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@akijakya akijakya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@csatib02 csatib02 merged commit 2f964fb into main Aug 14, 2024
32 checks passed
@csatib02 csatib02 deleted the feat/aws-support-configmap branch August 14, 2024 11:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@akijakya akijakya akijakya approved these changes

@sagikazarmark sagikazarmark Awaiting requested review from sagikazarmark

@ramizpolic ramizpolic Awaiting requested review from ramizpolic

Assignees

@csatib02 csatib02

Labels
area/provider/aws kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csatib02 @akijakya