-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ci: add magic nix cache #107
Conversation
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
I don't see much difference in pipeline steps with and without caching, is this maybe because this was the first execution or perhaps that it's not present on main branch, @sagikazarmark ? |
a30d26b
to
e0b5e93
Compare
Main branch (without caching): https://github.com/bank-vaults/vault-operator/actions/workflows/ci.yaml?query=branch%3Amain Cache branch: https://github.com/bank-vaults/vault-operator/actions/workflows/ci.yaml?query=branch%3Anix-cache Test job without caching: ~7 minutes |
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvements 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Managed to improve things further by segmenting the Go cache for each job. It takes up more space in the cache, but different jobs download different dependencies (eg. build doesn't download test dependencies, etc) |
Overview
Fixes #105
Notes for reviewer