feat: upgrade bank-vaults #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagikazarmark
force-pushed
the
bank-vaults-upgrade
branch
3 times, most recently
from
ac3d8ab to
c2c1142
Compare
|
Hi! I tested why the softhsm test fails locally, the configurer throws this error:
And the reason seems to be that softhsm is no longer built into the |
|
Thanks for checking! Looks like I forgot to put softhsm back to the image. |
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
sagikazarmark
force-pushed
the
bank-vaults-upgrade
branch
from
c2c1142 to
a977445
Compare
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
sagikazarmark
force-pushed
the
bank-vaults-upgrade
branch
from
ba881f5 to
b0c4e77
Compare
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
|
Finally! |
ramizpolic
approved these changes
Jul 26, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #113