Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: parse docker image references in accordance with the standard grammar #139

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

sagikazarmark
Copy link
Member

Overview

Fixes #95

Notes for reviewer

…ammar

Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
@sagikazarmark sagikazarmark added the kind/bug Categorizes issue or PR as related to a bug. label Jul 27, 2023
@sagikazarmark sagikazarmark added this to the v1.21.0 milestone Jul 27, 2023
@sagikazarmark sagikazarmark requested a review from ramizpolic July 27, 2023 16:25
@sagikazarmark sagikazarmark merged commit 14c1ae7 into main Jul 28, 2023
@sagikazarmark sagikazarmark deleted the fix-docker-image-ref branch July 28, 2023 08:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Incorrect ServiceMonitor.spec.endpoints when docker registry proxy with custom port used to pull vault image
2 participants