fix: make HSM pin an optional argument to allow setting it via the BANK_VAULTS_HSM_PIN env var #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mark64, thanks for raising this! I will look into this one once I am back from PTO, apologies for taking a bit longer. I just need to verify how this specific config flag is passed downstream. |
ramizpolic
reviewed
Jan 23, 2024
…ULTS_HSM_PIN env var Signed-off-by: Mark Hill <markleehill@gmail.com>
mark64
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previously, the pin had to be provided by the user in their Vault yaml. If you want to keep the pin secret in
source code, then this isn't desirable. Viper defaults to the command line version of the pin, so even if you
set a dummy pin in the yaml and override it via
envsConfig, bank-vaults won't use the right pin.Notes for reviewer
This is my first PR here so please check if I missed things that need to be updated.