Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: Pod disruption budget #324

Merged
merged 1 commit into from
Jan 18, 2024
Merged

feat: Pod disruption budget #324

merged 1 commit into from
Jan 18, 2024

Conversation

camaeel
Copy link
Contributor

@camaeel camaeel commented Dec 28, 2023

Overview

Implement pod disruption budget for vault-operator helm-chart

Fixes #323

Notes for reviewer

@camaeel camaeel requested a review from a team as a code owner December 28, 2023 15:00
@camaeel camaeel requested review from akijakya and removed request for a team December 28, 2023 15:00
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-99 lines label Dec 28, 2023
akijakya
akijakya previously approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@akijakya akijakya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @camaeel, thanks for your contribution! Could you take a look at the linting error?

@camaeel camaeel force-pushed the pdb branch 3 times, most recently from f15f931 to 9549514 Compare January 9, 2024 22:12
@camaeel
Copy link
Contributor Author

camaeel commented Jan 9, 2024

@akijakya should be fixed now

@akijakya
Copy link
Member

Please also run make gen-helm-docs, so the new values are included in the chart readme, thanks!

@ramizpolic
Copy link
Member

Please also run make gen-helm-docs, so the new values are included in the chart readme, thanks!

Hi @camaeel, could you please resolve this so we can merge it? Thanks!

@camaeel
Copy link
Contributor Author

camaeel commented Jan 17, 2024

Done

@camaeel
feat: Pod disruption budget
f29f5d2 
Signed-off-by: camaeel <12999736+camaeel@users.noreply.github.com>

Update pdb.yaml

fix

update docs
ramizpolic
ramizpolic approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission @camaeel!

@ramizpolic ramizpolic merged commit a7b812e into bank-vaults:main Jan 18, 2024
31 checks passed
@camaeel camaeel deleted the pdb branch January 18, 2024 10:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ramizpolic ramizpolic ramizpolic approved these changes

@akijakya akijakya akijakya left review comments

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm chart should provide a PDB
3 participants
@camaeel @akijakya @ramizpolic