Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CI update k8s and vault versions #38

Merged
merged 3 commits into from
May 26, 2023
Merged

Conversation

akijakya
Copy link
Member

resolves #32

akijakya added 2 commits May 26, 2023 15:50
Signed-off-by: András Jáky <ajaky@cisco.com>
Signed-off-by: András Jáky <ajaky@cisco.com>
@akijakya akijakya self-assigned this May 26, 2023
@@ -87,8 +87,8 @@ jobs:
needs: [artifacts]
strategy:
matrix:
k8s_version: ["v1.25.8", "v1.24.12", "v1.23.17"]
vault_version: ["1.13.1", "1.12.5", "1.11.9", "1.10.11"]
k8s_version: ["v1.24.13", "v1.25.9", "v1.26.4" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the latest kind release supports 1.27 as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats right, but afaik we agreed on that the in case of k8s, we support 3 versions until the latest-1 version.

Copy link
Member

@sagikazarmark sagikazarmark May 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused: why wouldn't we want to support the latest version? Unless of course there is some sort of incompatibility that keeps us from supporting it (and requires a breaking change to do so).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, but I agree that it wouldn't hurt to add the latest version to this matrix 🙂 Should we drop 1.24 or let this be a 4 element list?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I'd keep as much versions as we can.

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Signed-off-by: András Jáky <ajaky@cisco.com>
@sagikazarmark sagikazarmark merged commit 3f7dd93 into main May 26, 2023
@sagikazarmark sagikazarmark deleted the ci-update-k8s-versions branch May 26, 2023 19:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Kubernetes versions in test matrix
2 participants