-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
CI update k8s and vault versions #38
Conversation
Signed-off-by: András Jáky <ajaky@cisco.com>
Signed-off-by: András Jáky <ajaky@cisco.com>
.github/workflows/ci.yaml
Outdated
@@ -87,8 +87,8 @@ jobs: | |||
needs: [artifacts] | |||
strategy: | |||
matrix: | |||
k8s_version: ["v1.25.8", "v1.24.12", "v1.23.17"] | |||
vault_version: ["1.13.1", "1.12.5", "1.11.9", "1.10.11"] | |||
k8s_version: ["v1.24.13", "v1.25.9", "v1.26.4" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the latest kind release supports 1.27 as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats right, but afaik we agreed on that the in case of k8s, we support 3 versions until the latest-1 version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused: why wouldn't we want to support the latest version? Unless of course there is some sort of incompatibility that keeps us from supporting it (and requires a breaking change to do so).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, but I agree that it wouldn't hurt to add the latest version to this matrix 🙂 Should we drop 1.24 or let this be a 4 element list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I'd keep as much versions as we can.
Signed-off-by: András Jáky <ajaky@cisco.com>
resolves #32