Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Skip CA Secret Upsert for Namespace in Terminating state #395

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

sid8489
Copy link
Contributor

@sid8489 sid8489 commented Mar 6, 2024

Issue - Vault-Operator fails to create vault-tls secret for new namespaces if any existing namespace is in Terminating State.

Fix -> Skip the namespaces in terminating state.

Signed-off-by: sid8489 <agrawal8489@gmail.com>
@sid8489 sid8489 requested a review from a team as a code owner March 6, 2024 08:27
@sid8489 sid8489 requested review from sagikazarmark and removed request for a team March 6, 2024 08:27
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines label Mar 6, 2024
@csatib02 csatib02 requested review from akijakya and removed request for sagikazarmark March 6, 2024 08:56
Copy link
Member

@akijakya akijakya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@akijakya akijakya merged commit 58fed42 into bank-vaults:main Mar 12, 2024
31 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
size/XS Denotes a PR that changes 0-9 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants