Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add option to allow TLS termination by load balancers #437

Merged

Conversation

nate-ribelin
Copy link
Contributor

Overview

This feature allows the operator to use an override for API Scheme (http/https) when calling the Raft leader. If the user does not want to use TLS within Vault, but rather have a reverse proxy and/or load balancer terminate the connection, this override allows http or https to be added to the raftLeaderAddress. By default, this API Scheme is set based upon values provided in the Vault config for TLS. This is non-intrusive and will only override the raftLeaderAddress value if provided.

Signed-off-by: nathan.ribelin <nathan.ribelin@iherb.com>
@nate-ribelin nate-ribelin requested a review from a team as a code owner April 18, 2024 19:03
@nate-ribelin nate-ribelin requested review from sagikazarmark and removed request for a team April 18, 2024 19:03
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-99 lines label Apr 18, 2024
@nate-ribelin nate-ribelin changed the title Add option to allow TLS termination by load balancers feat: Add option to allow TLS termination by load balancers Apr 18, 2024
@csatib02 csatib02 added kind/enhancement Categorizes issue or PR as related to an improvement. kind/feature Categorizes issue or PR as related to a new feature. area/storage labels Apr 19, 2024
@csatib02 csatib02 requested review from ramizpolic and akijakya April 19, 2024 05:38
@csatib02 csatib02 removed the kind/enhancement Categorizes issue or PR as related to an improvement. label Apr 19, 2024
Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @nate-ribelin!

@csatib02 csatib02 merged commit 3d710b9 into bank-vaults:main Apr 22, 2024
34 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/storage kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-99 lines
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants