Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: bump go version, update nix #448

Merged
merged 9 commits into from
May 27, 2024
Merged

chore: bump go version, update nix #448

merged 9 commits into from
May 27, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Apr 22, 2024 •
edited
Loading

Overview

@csatib02 csatib02 requested review from ramizpolic and akijakya April 22, 2024 08:10
@csatib02 csatib02 self-assigned this Apr 22, 2024
@csatib02 csatib02 requested a review from a team as a code owner April 22, 2024 08:10
@github-actions github-actions bot added the size/M Denotes a PR that changes 100-499 lines label Apr 22, 2024
@csatib02 csatib02 added the triage/on-hold Indicates an issue or PR is on hold for some reason. label Apr 22, 2024
@csatib02
chore: bump go version, update dependencies
3b10cca 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 csatib02 force-pushed the chore/bump-go-version-update-dependencies branch from 1ab167d to 3b10cca Compare May 6, 2024 06:44
@csatib02 csatib02 removed the request for review from a team May 6, 2024 06:59
@csatib02 csatib02 changed the title chore: bump go version, update dependencies chore: bump go version, update dependencies, address breaking changes May 6, 2024
@csatib02 csatib02 removed the triage/on-hold Indicates an issue or PR is on hold for some reason. label May 6, 2024
@csatib02
fix: address breaking change, update deps
bbb4d31 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@github-actions github-actions bot added size/XL Denotes a PR that changes 1000+ lines and removed size/M Denotes a PR that changes 100-499 lines labels May 6, 2024
This was referenced May 6, 2024
Closed
Closed
@ramizpolic ramizpolic added the triage/on-hold Indicates an issue or PR is on hold for some reason. label May 10, 2024
@ramizpolic ramizpolic changed the title chore: bump go version, update dependencies, address breaking changes chore: bump go version May 10, 2024
@ramizpolic
Copy link
Member

The pipeline (maybe NIX too) also need to be updated to use proper Go version

This was referenced May 13, 2024
Closed
Closed
csatib02 added 2 commits May 13, 2024 09:58
@csatib02
+1
dd754ed 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02
chore: bump go version for nix
546662c 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 csatib02 force-pushed the chore/bump-go-version-update-dependencies branch from 055cfae to 546662c Compare May 13, 2024 11:54
@csatib02
chore: update nix
2268124 
Signed-off-by: Bence Csati <bcsati@cisco.com>
ramizpolic
ramizpolic reviewed May 15, 2024
View reviewed changes
flake.nix Show resolved Hide resolved
@csatib02
fix: use vault package as service in nix
228c19e 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 csatib02 requested a review from ramizpolic May 15, 2024 12:01
@csatib02
chore: upgrade dependencies
b2cf6d8 
Signed-off-by: Bence Csati <bcsati@cisco.com>
This was referenced May 20, 2024
Closed
Closed
@csatib02
chore: address breaking change
e2304bf 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 csatib02 changed the title chore: bump go version chore: bump go version, update nix May 24, 2024
This was referenced May 27, 2024
Closed
Closed
Closed
Closed
@csatib02
chore: +1
eebf743 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 csatib02 removed the triage/on-hold Indicates an issue or PR is on hold for some reason. label May 27, 2024
@csatib02 csatib02 merged commit 661263a into main May 27, 2024
32 of 33 checks passed
@csatib02 csatib02 deleted the chore/bump-go-version-update-dependencies branch May 27, 2024 12:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@akijakya akijakya akijakya approved these changes

@ramizpolic ramizpolic Awaiting requested review from ramizpolic

Assignees

@csatib02 csatib02

Labels
area/dependencies size/XL Denotes a PR that changes 1000+ lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csatib02 @ramizpolic @akijakya