Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: Add CRD Support for Oracle Cloud Infrastructure #457

Merged
merged 1 commit into from
May 2, 2024
Merged

feat: Add CRD Support for Oracle Cloud Infrastructure #457

merged 1 commit into from
May 2, 2024

Conversation

jynolen
Copy link
Contributor

@jynolen jynolen commented Apr 29, 2024 •
edited
Loading

Overview

This PR is the sister PR of bank-vaults/bank-vaults#2660
It adds CRD Support for Oracle Cloud Infrastructure

Notes for reviewer

See bank-vaults/bank-vaults#2660 for complete implementation

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-99 lines label Apr 29, 2024
@jynolen jynolen mentioned this pull request Apr 29, 2024
Merged
@jynolen jynolen marked this pull request as ready for review April 29, 2024 14:23
@jynolen jynolen requested a review from a team as a code owner April 29, 2024 14:23
@jynolen jynolen requested review from ramizpolic and removed request for a team April 29, 2024 14:23
@csatib02 csatib02 added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 29, 2024
@jynolen
Copy link
Contributor Author

jynolen commented Apr 29, 2024

Required Changes had been performed

@csatib02
Copy link
Member

csatib02 commented Apr 30, 2024 •
edited
Loading

Also please change this line in the makefile:

# Dependency versions
GOLANGCI_VERSION = 1.53.3
LICENSEI_VERSION = 0.8.0
KIND_VERSION = 0.20.0
KURUN_VERSION = 0.7.0
CODE_GENERATOR_VERSION = 0.27.1
HELM_DOCS_VERSION = 1.11.0
KUSTOMIZE_VERSION = 5.1.0
CONTROLLER_TOOLS_VERSION = 0.15.0 # <-- This line

Delete the bin folder, then run make deps again, finally run make generate.
You can commit the controller-tools-version change too, since it had nil pointer issues in the past.

@jynolen
feat: Add CRD Support for Oracle Cloud Infrastructure
0a17969 
Signed-off-by: Jean-Yves NOLEN <jynolen@gmail.com>
@jynolen
Copy link
Contributor Author

jynolen commented Apr 30, 2024

Changed done

csatib02
csatib02 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@csatib02 csatib02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ramizpolic
Copy link
Member

Depends on bank-vaults/bank-vaults#2660

@ramizpolic ramizpolic added the triage/on-hold Indicates an issue or PR is on hold for some reason. label May 2, 2024
@ramizpolic ramizpolic removed the triage/on-hold Indicates an issue or PR is on hold for some reason. label May 2, 2024
@ramizpolic ramizpolic merged commit dce4857 into bank-vaults:main May 2, 2024
31 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@csatib02 csatib02 csatib02 approved these changes

@ramizpolic ramizpolic ramizpolic approved these changes

Assignees

@jynolen jynolen

Labels
kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-99 lines
Projects
Community contributions
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jynolen @csatib02 @ramizpolic