Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(vault-operator helm chart): added missing common.capabilities.kubeVersion and common.capabilities.policy.apiVersion template definitions. #527

Merged
merged 1 commit into from
Jul 28, 2024
Merged

fix(vault-operator helm chart): added missing common.capabilities.kubeVersion and common.capabilities.policy.apiVersion template definitions. #527

merged 1 commit into from
Jul 28, 2024

Conversation

virtyaluk
Copy link
Contributor

Overview

Fixes: #526

Notes for reviewer

Added missing common.capabilities.kubeVersion and common.capabilities.policy.apiVersion template definitions.

@virtyaluk virtyaluk requested a review from a team as a code owner July 9, 2024 12:55
@virtyaluk virtyaluk requested review from ramizpolic and removed request for a team July 9, 2024 12:55
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-99 lines label Jul 9, 2024
@csatib02 csatib02 added kind/bug Categorizes issue or PR as related to a bug. area/artifacts labels Jul 10, 2024
akijakya
akijakya approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@akijakya akijakya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Could you please sign off your commit to satisfy the DCO? If you click on the failed check there are some instructions on it!

@virtyaluk
fix(vault-operator helm chart): added missing common.capabilities.kub…
efe75e6 
…eVersion and common.capabilities.policy.apiVersion template definitions.

Signed-off-by: virtyaluk <bohdan@modern-dev.com>
@virtyaluk
Copy link
Contributor Author

Hey @akijakya, I updated the commit to pass the check. Please take a look. Thanks.

csatib02
csatib02 approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@csatib02 csatib02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csatib02 csatib02 merged commit 3bc6fe5 into bank-vaults:main Jul 28, 2024
31 checks passed
@csatib02 csatib02 mentioned this pull request Jul 28, 2024
Closed
3 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@csatib02 csatib02 csatib02 approved these changes

@akijakya akijakya akijakya approved these changes

@ramizpolic ramizpolic Awaiting requested review from ramizpolic ramizpolic is a code owner automatically assigned from bank-vaults/maintainers

@sagikazarmark sagikazarmark Awaiting requested review from sagikazarmark

Assignees

@virtyaluk virtyaluk

Labels
area/artifacts kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-99 lines
Projects
Community contributions
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm template error when deploying using ArgoCD
3 participants
@virtyaluk @akijakya @csatib02