Allows users to specify unseal key shares and key threshold #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farhan-pasha
requested review from
bonifaido,
akijakya and
sagikazarmark
as code owners
farhan-pasha
force-pushed
the
configurable-unseal-options
branch
2 times, most recently
from
bc0fb8e to
3af8a42
Compare
akijakya
previously approved these changes
Jun 9, 2023
akijakya
reviewed
Jun 9, 2023
farhan-pasha
force-pushed
the
configurable-unseal-options
branch
from
3af8a42 to
7120ed2
Compare
|
A much-awaited feature. Thank you @farhan-pasha!! |
sagikazarmark
requested changes
Jun 16, 2023
There was a problem hiding this comment.
@farhan-pasha Thanks! I'm in favor of this PR as well.
Can you please take a look at my comment? I can proceed with merging the PR afterwards.
farhan-pasha
force-pushed
the
configurable-unseal-options
branch
3 times, most recently
from
0d09b23 to
157ac05
Compare
…ed on their specific requirements. These configurations are made mode independent, providing users with better flexibility. The changes in this pull request also include modifications to the Custom Resource Definition (CRDs), a version bump, and updates to few example deployment YAML files. Fixes bank-vaults#56 Signed-off-by: Farhan Pasha <pfarhan@vmware.com>
farhan-pasha
force-pushed
the
configurable-unseal-options
branch
from
157ac05 to
9f29194
Compare
|
Hey @sagikazarmark, @akijakya could you please have a look and possibly approve the PR. |
akijakya
approved these changes
Jun 22, 2023
sagikazarmark
approved these changes
Jun 26, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allows users to specify unseal key shares and key threshold based on their specific requirements. The changes in this pull request also include modifications to the Custom Resource Definitions (CRDs), a version bump, and updates to a few example deployment YAML files.
Fixes #56
Notes for reviewer
This pull request introduces a different approach compared to PR-57, as this is mode independent(not just Kubernetes specific). Users will have the flexibility to utilize the
optionsfield inUnsealConfigto specify their desired values.Thank you :)