fix: update vault liveness probe to /sys/health for improved reliability #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roee-hersh
changed the title
roee-hersh
changed the title
csatib02
added
kind/enhancement
csatib02
reviewed
Dec 19, 2024
There was a problem hiding this comment.
LGTM!
Can you please update the comment above the Liveness-probe to: https://developer.hashicorp.com/vault/api-docs/system/health
Also, could you please sign your commits, there are instructions here: https://github.com/bank-vaults/vault-operator/pull/678/checks?check_run_id=34592516515
Signed-off-by: Roee Hershko <roee.hershko@riskified.com>
Signed-off-by: Bence Csati <bence.csati@axoflow.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the Vault liveness probe from
/v1/sys/initto/sys/health. The/v1/sys/initendpoint does not include health status, which can cause Vault to become inaccessible when its health fails. By aligning the liveness probe with the readiness probe to use/sys/health, we ensure consistent behavior and improved reliability.Additionally, this change aligns with the Vault official Helm chart, which also uses
/sys/healthfor both readiness and liveness probes, as specified here.This change comes in response to an issue where Vault stopped responding due to an unhealthy state. The issue required manually deleting the unhealthy pod to restore functionality. By using
/sys/health, this problem is mitigated as it ensures the liveness probe reflects Vault's actual health.Notes for reviewer
Let me know if you’d like further details or adjustments! 😊