Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade Kubernetes API to 1.27 #82

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Upgrade Kubernetes API to 1.27 #82

merged 3 commits into from
Jun 23, 2023

Conversation

ramizpolic
Copy link
Member

@ramizpolic ramizpolic commented Jun 21, 2023

Overview

Tracks #47

Notes for reviewer

  • controller-runtime interfaces have slightly changed, the new changes take those into account

@ramizpolic
Copy link
Member Author

Maybe we could also bump CI acceptance test Kube version against v1.27.2

@akijakya
Copy link
Member

akijakya commented Jun 21, 2023

Maybe we could also bump CI acceptance test Kube version against v1.27.2

Here 😉 #83 (with 1.27.3 though)

@sagikazarmark
Copy link
Member

These are breaking change, right?

* `vaultv1alpha1.Vault.Spec.PodAntiAffinity` has been replaced with `vaultv1alpha1.Vault.Spec.Affinity.PodAntiAffinity`

* `vaultv1alpha1.Vault.Spec.PodAffinity` has been replaced with `vaultv1alpha1.Vault.Spec.Affinity.PodAffinity`

Do we need a webhook and a new API version to support backward compatibility (ie. if someone updates the operator to a version with this change, it shouldn't break existing instances)?

@sagikazarmark sagikazarmark added the kind/enhancement Categorizes issue or PR as related to an improvement. label Jun 22, 2023
@sagikazarmark
Copy link
Member

Merge branch 'main' into feature/k8s.io-v0.27.2

Please rebase instead of merging main.

@ramizpolic ramizpolic force-pushed the feature/k8s.io-v0.27.2 branch from 5966a56 to 58b1797 Compare June 22, 2023 11:27
Signed-off-by: Ramiz Polic <ramiz.polic@hotmail.com>
Signed-off-by: Ramiz Polic <ramiz.polic@hotmail.com>
@ramizpolic ramizpolic force-pushed the feature/k8s.io-v0.27.2 branch from 58b1797 to 2e00e1f Compare June 22, 2023 11:45
@ramizpolic
Copy link
Member Author

ramizpolic commented Jun 22, 2023

I will move API these changes to a separate PR since it will require a bit more work. This PR does not really benefit from those changes, so I will rollback to ones without it.

Signed-off-by: Ramiz Polic <ramiz.polic@hotmail.com>
@ramizpolic ramizpolic self-assigned this Jun 22, 2023
Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramizpolic ramizpolic merged commit 95505ae into main Jun 23, 2023
@ramizpolic ramizpolic deleted the feature/k8s.io-v0.27.2 branch June 23, 2023 12:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/enhancement Categorizes issue or PR as related to an improvement.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants