feat: Add configurable AWS KMS encryption context #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirilvasilev
requested review from
bonifaido,
akijakya and
sagikazarmark
as code owners
kirilvasilev
force-pushed
the
feat/add_configurable_awskms_encryption_context
branch
10 times, most recently
from
ff63278 to
315fcc0
Compare
|
Thanks for this MR |
kirilvasilev
force-pushed
the
feat/add_configurable_awskms_encryption_context
branch
2 times, most recently
from
1e12dc1 to
56c4802
Compare
ramizpolic
requested changes
Jun 22, 2023
kirilvasilev
force-pushed
the
feat/add_configurable_awskms_encryption_context
branch
4 times, most recently
from
1bc7edd to
00f4aeb
Compare
akijakya
previously approved these changes
Jun 22, 2023
sagikazarmark
previously approved these changes
Jun 22, 2023
sagikazarmark
added
the
kind/enhancement
kirilvasilev
force-pushed
the
feat/add_configurable_awskms_encryption_context
branch
4 times, most recently
from
ec7b8d9 to
35fc867
Compare
kirilvasilev
force-pushed
the
feat/add_configurable_awskms_encryption_context
branch
2 times, most recently
from
917426b to
dfe0b2f
Compare
|
@kirilvasilev would you mind updating the PR? The recent repo changes moved the deployment resources, so this PR is affected. Thanks! |
kirilvasilev
dismissed stale reviews from akijakya and sagikazarmark
via
f4cacaa
kirilvasilev
force-pushed
the
feat/add_configurable_awskms_encryption_context
branch
from
dfe0b2f to
f4cacaa
Compare
ramizpolic
previously approved these changes
Jun 28, 2023
Signed-off-by: @kirilvasilev <kiril.v92@gmail.com> Signed-off-by: Kiril Vasilev <kiril.v92@gmail.com>
kirilvasilev
force-pushed
the
feat/add_configurable_awskms_encryption_context
branch
from
f4cacaa to
6cb68cd
Compare
sagikazarmark
approved these changes
Jul 26, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Features:
This PR is created in order to allow the vault operator to take advantage of this bank-vaults feature
Notes for reviewer
In our use case, we have an existing vault cluster that has existing unseal keys that are encrypted with a custom encryption context. This feature will allow us to migrate this vault cluster to be managed by bank-vaults.