Update README.md #99
Merged
Update README.md #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add oci protocol to helm chart url so that command works as is
oche-jay
requested review from
bonifaido,
akijakya and
sagikazarmark
as code owners
|
One more thing though: could you please sign off your commit so the DCO check passes? |
sagikazarmark
approved these changes
Jul 10, 2023
sagikazarmark
approved these changes
Jul 26, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I added the
ociprotocol to helm chart URL, so that the installation command works as is.Notes for reviewer
The command as it is, returns the following error