Merge pull request cisco-open#107 from tiswanso/fix-logsink-addvalues

Fix logsink addvalues
banzaicloud · Jun 23, 2022 · e4fbb0a · e4fbb0a
2 parents f33bcfd + d3d1ee9
commit e4fbb0a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/pkg/logger/logger.go b/pkg/logger/logger.go
@@ -85,9 +85,8 @@ func (log *logger) WithName(name string) Logger {
 
 func (log *logger) WithValues(keysAndValues ...interface{}) Logger {
 	sink := log.sink.copyLogger()
-	for k, v := range keysAndValues {
-		sink.values[k] = v
-	}
+
+	sink.values = keysAndValues
 
 	return &logger{
 		level: log.level,

diff --git a/pkg/logger/logsink.go b/pkg/logger/logsink.go
@@ -223,9 +223,7 @@ func (log *SpinnerLogSink) GetValues() []interface{} {
 }
 
 func (log *SpinnerLogSink) AddValues(keyAndValues []interface{}) {
-	for k, v := range keyAndValues {
-		log.values[k] = v
-	}
+	log.values = append(log.values, keyAndValues...)
 }
 
 func (log *SpinnerLogSink) AddName(name string) {