-
Notifications
You must be signed in to change notification settings - Fork 45
"NoPrintConversion" functional option #24
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Added a function to parse additional initial arguments to exiftool. Signed-off-by: Kjeldgaard <Kjeldgaard@users.noreply.github.com>
Added comments and sample to AddInitArgs() function. Signed-off-by: Kjeldgaard <Kjeldgaard@users.noreply.github.com>
Hi @Kjeldgaard, thanks for the PR ! This feature is bothering me:
But since I consider that this feature might interest some users, let's do this this way:
|
Hi barasher, Thanks for your comment. I totalky understand your concerns about this change, as it could break go-exiftool functionality. Since it is actually only the "-n" argument I need, I have come to the conclusion that it would probably be better to achieve this similarly to the charset implementation. What do you think? |
I've taken a look at exiftool's |
New dedicated function for 'No Print Conversion' mode. Signed-off-by: Kjeldgaard <Kjeldgaard@users.noreply.github.com>
I've made a new dedicated function for 'No Print Conversion'. What do you think? |
exiftool.go
Outdated
} | ||
|
||
// Function to use 'No print conversion' mode, see https://exiftool.org/exiftool_pod.html. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation does not fit godoc specifications. The comment should start with the name fonction.
https://blog.golang.org/godoc
Just a little godoc fix and that will be perdect :) |
Fix NoPrintConversion comment to follow godoc spec. Signed-off-by: Kjeldgaard <Kjeldgaard@users.noreply.github.com>
Didn't know that was a thing :) It should be fixed now. |
Thanks a lot @Kjeldgaard , I'll merge this feature tomorrow and release a new version |
You're welcome. Glad I could contribute to go-exiftool. |
New function which adds initial arguments to be parsed to exiftool.