-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update zap-snapshots.sh #92
base: main
Are you sure you want to change the base?
Conversation
This is absolutely not the purpose of zap-snapshots.sh. To avoid confusion, I think I'll rename zap-snapshots.sh to delete-old-snapshots.sh. Then I can integrate this as delete-all-snapshots.sh. I'll deal with this later this weekend. |
sounds good! 😄 |
On second thought, what I might do instead is leave zap-snapshots.sh with its current name and current default behavior, but add a --all/-a command line option to make it do all snapshots like StarPlayrX's. I'll think about it more and then resolve it, one way or the other, later tonight (or possibly tomorrow, but probably tonight). |
Unfortunately, since my last comment some stuff in my life has started going crazy, so I'll have to release v0.5.0 without this and merge this into v0.5.1 when things settle down, maybe toward the end of the week or the weekend. Sorry. |
I'm trying to get v0.5.1 out before Big Sur itself, or at least not too long afterward, so I've run out of time to merge this for v0.5.1. I'll merge this for v0.5.2 or v0.5.3. Sorry. |
After seeing the latest changes, I'm a bit confused about what this code is trying to do (or, to be more clear, what advantages it has over my existing code). For the moment, I'll err on the side of not merging this in any form, while I work on higher priority fixes. (But this is not a final decision, so I'll leave the pull request open.) |
023b0df
to
06527cb
Compare
06527cb
to
e36718b
Compare
Added StarPlayrX snapshot purge command to help completely erase pesky snapshots fully on the newer betas including 11.0.1