Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Duplicated pivot relationships in 3.2.1 #1606

Closed
rpatew2c opened this issue Oct 28, 2024 · 1 comment
Closed

Duplicated pivot relationships in 3.2.1 #1606

rpatew2c opened this issue Oct 28, 2024 · 1 comment

Comments

@rpatew2c
Copy link

rpatew2c commented Oct 28, 2024 •
edited
Loading

There's a small issue with the docblocks #1597 generates. If the type is already present, it is duplicated. Here is a sample from my codebase running the latest 3.2.1 of ide-helper

- * @property-read \Modules\Contacts\Infrastructure\Models\Phonable|\Modules\Contacts\Infrastructure\Models\Emailable|\Modules\Contacts\Infrastructure\Models\Mailable|null $pivot
+ * @property-read \Modules\Contacts\Infrastructure\Models\Phonable|\Modules\Contacts\Infrastructure\Models\Phonable|\Modules\Contacts\Infrastructure\Models\Emailable|\Modules\Contacts\Infrastructure\Models\Emailable|\Modules\Contacts\Infrastructure\Models\Mailable|\Modules\Contacts\Infrastructure\Models\Mailable|null $pivot

Originally posted by @rpatew2c in #1597 (comment)
pataar added a commit to pataar/laravel-ide-helper that referenced this issue Oct 28, 2024
@pataar
fix(pivot): only use unique classes in the pivot union (Fixes barryvd…
970a10a 
…h#1606)
@pataar
Copy link
Contributor

pataar commented Oct 28, 2024 •
edited
Loading

My bad! Will be resolved in #1607 :)

pataar added a commit to pataar/laravel-ide-helper that referenced this issue Oct 28, 2024
@pataar
fix(pivot): only use unique classes in the pivot union (Fixes barryvd…
c0ca34d 
…h#1606)

improve comment

composer fix-style

use a safer method
pataar added a commit to pataar/laravel-ide-helper that referenced this issue Oct 28, 2024
@pataar
# This is a combination of 2 commits.
4a2bbaf 
# This is the 1st commit message:

fix(pivot): only use unique classes in the pivot union (Fixes barryvdh#1606)

improve comment

composer fix-style

use a safer method

# This is the commit message #2:

unshift is better than rest
pataar added a commit to pataar/laravel-ide-helper that referenced this issue Oct 28, 2024
@pataar
# This is a combination of 3 commits.
8806fe5 
# This is the 1st commit message:

fix(pivot): only use unique classes in the pivot union (Fixes barryvdh#1606)

improve comment

composer fix-style

use a safer method

# This is the commit message #2:

unshift is better than rest

# This is the commit message barryvdh#3:

composer fix-style
# This is a combination of 3 commits.
# This is the 1st commit message:

fix(pivot): only use unique classes in the pivot union (Fixes barryvdh#1606)

improve comment

composer fix-style

use a safer method

# This is the commit message #2:

unshift is better than rest

# This is the commit message barryvdh#3:

composer fix-style
pataar added a commit to pataar/laravel-ide-helper that referenced this issue Oct 28, 2024
@pataar
fix(pivot): only use unique classes in the pivot union (Fixes barryvd…
9e17811 
…h#1606)
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pataar @rpatew2c