Add option to force usage of FQN #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfn
approved these changes
Sep 1, 2020
| @@ -1067,8 +1067,9 @@ protected function getClassNameInDestinationFile(object $model, string $classNam | |||
| $className = trim($className, '\\'); | |||
| $writingToExternalFile = !$this->write; | |||
| $classIsNotInExternalFile = $reflection->getName() !== $className; | |||
| $forceFQCN = $this->laravel['config']->get('ide-helper.force_fqn', false); | |||
There was a problem hiding this comment.
I suggest to stay consistent regarding the abbreviation:
Suggested change
| $forceFQCN = $this->laravel['config']->get('ide-helper.force_fqn', false); | |
| $forceFQN = $this->laravel['config']->get('ide-helper.force_fqn', false); |
|
@mfn seems getUsedClassNames method also need check for force_fqn? |
|
@UksusoFF 🤷♀️ I don't use that option. Can you create a PR with tests? |
|
Seems it's some unexpected behavior with my code. Will check it. |
|
Okay, thanks for checking 👍 Please keep us updated! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1007