Allowing Methods to be set or unset in ModelHooks #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfn
reviewed
Apr 1, 2021
|
Added in some tests |
barryvdh
approved these changes
Apr 3, 2021
mfn
reviewed
Apr 3, 2021
| @@ -749,7 +749,7 @@ public function setProperty($name, $type = null, $read = null, $write = null, $c | |||
| } | |||
| } | |||
|
|
|||
| protected function setMethod($name, $type = '', $arguments = [], $comment = '') | |||
| public function setMethod($name, $type = '', $arguments = [], $comment = '') | |||
There was a problem hiding this comment.
As with #945 (comment) , this will bring the same kind of breaking change.
So maybe in this case we should bump the major?
There was a problem hiding this comment.
I don't know, I think the impact is pretty small. The intended use case is not to provide an extensible package for all methods imho.
mfn
approved these changes
Apr 3, 2021
There was a problem hiding this comment.
Let's merge it, but wait for a release a bit, see #1198 (comment)
5 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Expanding PR #945 to include support in ModelHooks to unset and set Methods.
This can be useful for defining class inheritance properly for the IDE.
Type of change
Checklist
composer fix-style