-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
return mixed
if we failed detect castable type
#1306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, at first glance LGTM!
Please ping me once it's reviewable and please also add a changelog entry; I think we'll push out a patchi ASAP!
@mfn should be ready to review. I also checked it with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ping @barryvdh
### Fixed - Properly handle `Castable`s without return type. [barryvdh#1306 / binotaliu](barryvdh#1306)
### Fixed - Properly handle `Castable`s without return type. [#1306 / binotaliu](barryvdh/laravel-ide-helper#1306)
### Fixed - Properly handle `Castable`s without return type. [#1306 / binotaliu](barryvdh/laravel-ide-helper#1306)
### Fixed - Properly handle `Castable`s without return type. [#1306 / binotaliu](barryvdh/laravel-ide-helper#1306)
### Fixed - Properly handle `Castable`s without return type. [#1306 / binotaliu](barryvdh/laravel-ide-helper#1306)
### Fixed - Properly handle `Castable`s without return type. [barryvdh#1306 / binotaliu](barryvdh#1306)
fixed #1305
Summary
Type of change
Checklist
composer fix-style