Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

return mixed if we failed detect castable type #1306

Merged
merged 1 commit into from
Jan 24, 2022
Merged

return mixed if we failed detect castable type #1306

merged 1 commit into from
Jan 24, 2022

Conversation

binotaliu
Copy link
Contributor

@binotaliu binotaliu commented Jan 24, 2022

fixed #1305

Summary

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, at first glance LGTM!

Please ping me once it's reviewable and please also add a changelog entry; I think we'll push out a patchi ASAP!

@binotaliu binotaliu marked this pull request as ready for review January 24, 2022 08:51
@binotaliu
Copy link
Contributor Author

@mfn should be ready to review. I also checked it with AsArrayObject and it worked as expected (with mixed in docblock).

Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Ping @barryvdh

@barryvdh barryvdh merged commit 2673bf4 into barryvdh:master Jan 24, 2022
mfn added a commit to mfn/laravel-ide-helper that referenced this pull request Jan 24, 2022
### Fixed
- Properly handle `Castable`s without return type. [barryvdh#1306 / binotaliu](barryvdh#1306)
@mfn mfn mentioned this pull request Jan 24, 2022
9 tasks
barryvdh pushed a commit that referenced this pull request Jan 24, 2022
### Fixed
- Properly handle `Castable`s without return type. [#1306 / binotaliu](#1306)
renaforsberg824 added a commit to renaforsberg824/ide-helper-laravel-developer that referenced this pull request Oct 5, 2022
### Fixed
- Properly handle `Castable`s without return type. [#1306 / binotaliu](barryvdh/laravel-ide-helper#1306)
lisadeloach63 added a commit to lisadeloach63/ide-helper-reso-laravel that referenced this pull request Oct 7, 2022
### Fixed
- Properly handle `Castable`s without return type. [#1306 / binotaliu](barryvdh/laravel-ide-helper#1306)
sadafrangian3 pushed a commit to sadafrangian3/ide-helper-laravel that referenced this pull request Oct 18, 2022
### Fixed
- Properly handle `Castable`s without return type. [#1306 / binotaliu](barryvdh/laravel-ide-helper#1306)
smile1130 added a commit to smile1130/laravel-IDE that referenced this pull request Jun 16, 2023
### Fixed
- Properly handle `Castable`s without return type. [#1306 / binotaliu](barryvdh/laravel-ide-helper#1306)
d3v2a pushed a commit to d3v2a/laravel-ide-helper that referenced this pull request Feb 16, 2024
d3v2a pushed a commit to d3v2a/laravel-ide-helper that referenced this pull request Feb 16, 2024
### Fixed
- Properly handle `Castable`s without return type. [barryvdh#1306 / binotaliu](barryvdh#1306)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModelsCommand->checkForCastableCasts does not support AsArrayObject
3 participants