Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

disable inspections of helper files #1486

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Conversation

eidng8
Copy link
Contributor

@eidng8 eidng8 commented Nov 28, 2023

Summary

Currently PS inspects all helper files and screems... This PR makes sure it doesn't inspect helper files.

Type of change

  • New feature (non-breaking change which adds functionality)

@barryvdh
Copy link
Owner

But you need the files to be inspected? Or which tools does this block?

@mfn
Copy link
Collaborator

mfn commented Dec 12, 2023

and screems.

Can you be more specific what it fixes for you?

FTR: only tested this (manually) for a few minutes, it seems it does not break anything. But it would more thorough testing to confirm this.

@eidng8
Copy link
Contributor Author

eidng8 commented Dec 16, 2023

It doesn't break anything. It's just that when performing inspection only whole project using PHPStorm, these helper files are insepcted too. Although inspecting the whole project this way results in inspection issues, it doesn't break anything in anyway.

@mfn
Copy link
Collaborator

mfn commented Dec 16, 2023

Yeah it looks like this won't break the use within the app 👍🏼

@barryvdh should we cut a new release from current master before merging and also releasing this?

We've already collected a few changes and should release them more incrementally 🤞🏼 WDYT?

@barryvdh barryvdh merged commit cc9ed44 into barryvdh:master Feb 7, 2024
58 checks passed
d3v2a pushed a commit to d3v2a/laravel-ide-helper that referenced this pull request Feb 16, 2024
* disables all jetbrains inspections

* disables all jetbrains' & phpcs' inspections
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants