Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add pivot class property #1518

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Conversation

d3v2a
Copy link
Contributor

@d3v2a d3v2a commented Feb 16, 2024

Summary

This PR add pivot property when using a pivot model on BelongsToMany relation

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md (not necessary)
  • Code style has been fixed via composer fix-style

@d3v2a d3v2a mentioned this pull request Feb 16, 2024
9 tasks
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank, can you add a test showing this feature please?

@barryvdh
Copy link
Owner

Hmm two tests are failing

Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@d3v2a
Copy link
Contributor Author

d3v2a commented Mar 9, 2024

@barryvdh Is there anything more to do?

@d3v2a d3v2a force-pushed the add_pivot_class_property branch from 2576db6 to d98b9df Compare March 10, 2024 11:42
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barryvdh Is there anything more to do?

Nah it's good, we just need "humans with time" to do it :)

@barryvdh barryvdh merged commit ac7e186 into barryvdh:master Mar 11, 2024
26 checks passed
@d3v2a d3v2a deleted the add_pivot_class_property branch March 11, 2024 15:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants