Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: unknown format PHPDoc #1538

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fix: unknown format PHPDoc #1538

merged 1 commit into from
Jul 12, 2024

Conversation

schrosis
Copy link
Contributor

Summary

Fixed PHPDoc with unknown formatting.
I set TValue to true, should I use bool ?

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

mfn
mfn approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit.

At least I know that phpstan supports this.

@barryvdh barryvdh merged commit 001091e into barryvdh:master Jul 12, 2024
@schrosis schrosis deleted the patch-1 branch July 13, 2024 02:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mfn mfn mfn approved these changes

Assignees

@barryvdh barryvdh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schrosis @mfn @barryvdh