Fix PHP 8.4 deprecations #1618
Merged
Fix PHP 8.4 deprecations #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeppeKnockaert
changed the title
JeppeKnockaert
force-pushed
the
fix-php84-deprecations
branch
from
93a3a97 to
8797ed4
Compare
JeppeKnockaert
force-pushed
the
fix-php84-deprecations
branch
from
8797ed4 to
13763ae
Compare
|
This would be great to get merged in. My logs are filling up with deprecation warnings |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes implicitly nullable parameters because these result in deprecation warnings for PHP 8.4.
https://www.php.net/manual/en/migration84.deprecated.php#migration84.deprecated.core.implicitly-nullable-parameter
Type of change
Checklist
composer fix-style