Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix inline doc-block for final models #955

Merged
merged 2 commits into from
Jun 20, 2020
Merged

Fix inline doc-block for final models #955

merged 2 commits into from
Jun 20, 2020

Conversation

Gummibeer
Copy link
Contributor

@Gummibeer Gummibeer commented Jun 19, 2020

fixes #766

I've added a search for final class {ModelClass} before searching for class {ModelClass} and changed the substr_replace() call to simply inject the doc-block instead of replacing the whole class ... string.
This made it easier to use both search needles and don't adjust the replace string.

@barryvdh barryvdh merged commit 7203ebe into barryvdh:master Jun 20, 2020
@Gummibeer Gummibeer deleted the fix-issue-766 branch June 20, 2020 06:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [ENHANCEMENT] Use final class
2 participants