Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

basedart and basedselfies web ecosystem #1497

Closed
wants to merge 1 commit into from

Conversation

barigyasi
Copy link

What changed? Why?
added BASEDART and BASEDSELFIES to the ecosystem page
Notes to reviewers

How has it been tested?

Copy link

vercel bot commented Dec 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2024 3:48pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 28, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

Copy link

vercel bot commented Dec 28, 2024

@barigyasi is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@wbnns
Copy link
Member

wbnns commented Dec 29, 2024

@barigyasi

Thanks for the updated PR. In review there are some issues:

  • For BASEDART it seems there are currently only two art pieces in the marketplace; could you confirm if this is correct?
  • For BASEDSELFIES the upload feature does not seem to be working; please fix

Also, please rebase and fix the merge conflict. 🙏

@wbnns wbnns added change(s) requested One or more changes have been requested base ecosystem review This is ecosystem related labels Dec 29, 2024
@barigyasi
Copy link
Author

barigyasi commented Dec 29, 2024 via email

@wbnns
Copy link
Member

wbnns commented Dec 30, 2024

@barigyasi Thanks for the info. Since the rebase still needs to be done, can you please split this into two separate PRs, one for each site?

@wbnns wbnns closed this Dec 30, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
base ecosystem review This is ecosystem related change(s) requested One or more changes have been requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants