Add riak_core_ring_manager:is_stable_ring/0 public API [JIRA: RIAK-1598] #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction.
The riak_core_ring_manager already has a mechanism to optimize ring access
during heavy churn to optimize for ETS based access and during heavy reads
to avail of the erlang constant pool via mochiglobal.
The ability to predicate activity on ring stability is however more
generally useful. For example, certain application commands intended for
cluster wide strongly consistent effect may be ill-advised during periods
of ring topology churn.
This patch simply refactors out the predicate into a public API so that it
can be used as such. The proposed API is:
riak_core_ring_manager:is_stable_ring() -> boolean().
As the logic is predicated on inactivity and not covered in unit tests no
tests were added as the default inactivity period is hardwired to 90 seconds
and not tunable.
| @@ -406,7 +410,10 @@ handle_call({ring_trans, Fun, Args}, _From, State=#state{raw_ring=Ring}) -> | |||
| handle_call({set_cluster_name, Name}, _From, State=#state{raw_ring=Ring}) -> | |||
| NewRing = riak_core_ring:set_cluster_name(Ring, Name), | |||
| State2 = prune_write_notify_ring(NewRing, State), | |||
| {reply, ok, State2}. | |||
| {reply, ok, State2}; | |||
| handle_call(is_stable_ring, _From, State) -> | |||
There was a problem hiding this comment.
Nitpick: Please use spaces after commas in tuples here and below for consistency with surrounding code in this file.
|
Hi @darach, |
Basho-JIRA
changed the title
…lter the comments meaning
|
Thank you for calling out the 👾's I didn't notice breaking with the surround style. |
borshop
added a commit
that referenced
this pull request
Mar 10, 2015
…g_manager Add riak_core_ring_manager:is_stable_ring/0 public API [JIRA: RIAK-1598] Reviewed-by: andrewjstone
|
@borshop merge |
|
Awesome! 💕 |
|
^ Love seeing these moments 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status of a ring as stable (no topology change in a promotion period) or not is of general utility.
This patch proposes to refactor the predicate check into a public API so that it can be made more
generally useful.