add encode, message, and proto for RpbGetBucketKeyPreflistReq|Rest #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2015
Closed
zeeshanlakhani
force-pushed
the
feature/zl/add-pb-req-resp-for-active-annoated-preflist
branch
2 times, most recently
from
65e1b38 to
bfdcbee
Compare
zeeshanlakhani
changed the title
hmmr
added a commit
that referenced
this pull request
Feb 7, 2015
This branch (see PR #105) is based on basho/riak_pb/feature/zl/add-pb-req-resp-for-active-annoated-preflist. There is a matching commit in basho/riak_kv in a newly created branch feature/az/api-entrypoints-coverage.
hmmr
added a commit
that referenced
this pull request
Feb 13, 2015
This branch (see PR #105) is based on basho/riak_pb/feature/zl/add-pb-req-resp-for-active-annoated-preflist. There is a matching commit in basho/riak_kv in a newly created branch feature/az/api-entrypoints-coverage.
hmmr
added a commit
that referenced
this pull request
Feb 16, 2015
This branch (see PR #105) is based on basho/riak_pb/feature/zl/add-pb-req-resp-for-active-annoated-preflist. There is a matching commit in basho/riak_kv in a newly created branch feature/az/api-entrypoints-coverage.
hmmr
added a commit
that referenced
this pull request
Feb 16, 2015
This branch (see PR #105) is based on basho/riak_pb/feature/zl/add-pb-req-resp-for-active-annoated-preflist. There is a matching commit in basho/riak_kv in a newly created branch feature/az/api-entrypoints-coverage.
This was referenced Feb 16, 2015
zeeshanlakhani
force-pushed
the
feature/zl/add-pb-req-resp-for-active-annoated-preflist
branch
from
bfdcbee to
d16ec77
Compare
| @@ -31,6 +31,8 @@ | |||
| 30,RpbResetBucketResp,riak | |||
| 31,RpbGetBucketTypeReq,riak | |||
| 32,RpbSetBucketTypeReq,riak | |||
| 33,Rpbgetbucketkeypreflistreq,riak | |||
There was a problem hiding this comment.
Make sure this is capitalized in the same way as the messages in the .proto file. Erlang lowercases everything, but Java and Python codegen rely on correct capitalization.
There was a problem hiding this comment.
Def. my bad on that.
zeeshanlakhani
changed the title
zeeshanlakhani
force-pushed
the
feature/zl/add-pb-req-resp-for-active-annoated-preflist
branch
2 times, most recently
from
09586ec to
9595378
Compare
zeeshanlakhani
force-pushed
the
feature/zl/add-pb-req-resp-for-active-annoated-preflist
branch
from
9595378 to
df64e7d
Compare
|
👍 df64e7d Java, Python, and Erlang generate correctly. Tests pass. |
borshop
added a commit
that referenced
this pull request
Feb 26, 2015
…ive-annoated-preflist add encode, message, and proto for RpbGetBucketKeyPreflistReq|Rest Reviewed-by: seancribbs
|
@borshop merge |
seancribbs
deleted the
feature/zl/add-pb-req-resp-for-active-annoated-preflist
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds PB Message Codes and encode fn.
33 - RpbGetBucketKeyPreflistReq
34 - RpbGetBucketKeyPreflistResp
Description
Part of RIAK-1481.
The active preflist will return primary/fallback partitions and nodes for the available nodes at the time of query. Primary/fallback will be annotated.
This involves updates to our RiakKV WB code, RiakPB, Riak-Erlang-Http-Client, Riak-Erlang-Client.
*The impetus for adding this to the API started with a mailing list question answered by Charlie Voiselle, http://lists.basho.com/pipermail/riak-users_lists.basho.com/2015-January/016527.html, which involved a snippet of code that we've given clients multiple times. This was then discussed with Russell Brown on HipChat, https://basho.hipchat.com/history/room/867200/2015/01/13?q=enterprising&t=rid-867200#12:23:22.
Other PRs in the series: