sync create w/ removals of wait_for_index #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeshanlakhani
changed the title
zeeshanlakhani
force-pushed
the
bugfix/zl/sync-create-index
branch
5 times, most recently
from
0afd0d1 to
1a63937
Compare
zeeshanlakhani
changed the title
zeeshanlakhani
force-pushed
the
bugfix/zl/sync-create-index
branch
from
1a63937 to
021330f
Compare
| [IndexName, Timeout]), | ||
| Pid ! timeout; | ||
| Error -> | ||
| lager:warning("Solr Core Error on index ~s: ~p", |
There was a problem hiding this comment.
Can this be rephrased to indicate the operation that caused the error? e.g. "Solr core error after trying to create index ~s: ~p"
* index metadata still propgates even if response takes longer than timeout and returns an error * update wm and pb interfaces maybe_create_index * update tests to remove unncessary wait
zeeshanlakhani
force-pushed
the
bugfix/zl/sync-create-index
branch
from
e840399 to
404a014
Compare
|
This is also in need of basho/riak_api#85. |
|
+1 404a014 |
borshop
added a commit
that referenced
this pull request
Mar 18, 2015
sync create w/ removals of wait_for_index Reviewed-by: aberghage
|
Looks good to me as well. |
|
@borshop merge |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk of updates for RIAK-1547, related to #402. And needs basho/riak_pb#112 (merged and w/ an updated tag) and basho/riak-erlang-client#207 (for them riak-tests).