Fix bin search error

bat · Aug 23, 2024 · edbf33f · edbf33f
1 parent 84cac09
commit edbf33f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/src/rqspline.jl b/src/rqspline.jl
@@ -303,7 +303,7 @@ function rqs_inverse(
     k2 = one(typeof(k1))
 
     # Is inside of range
-    isinside = (k1 < K) && (k1 > 0)
+    isinside = (1 <= k1 <= K)
     k = Base.ifelse(isinside, k1, k2)
 
     x_tmp = Base.ifelse(isinside, x, pX[k])  # Simplifies unnecessary calculations
@@ -352,7 +352,7 @@ end
     k2 = one(typeof(k1))
 
     # Is inside of range
-    isinside = (k1 < K) && (k1 > 0)
+    isinside = (1 <= k1 <= K)
     k = Base.ifelse(isinside, k1, k2)
 
     x_tmp = Base.ifelse(isinside, x[i,j], pX[k,i,j])  # Simplifies unnecessary calculations

diff --git a/src/utils.jl b/src/utils.jl
@@ -1,4 +1,4 @@
-# This file is a part of EuclidianNormalizingFlows.jl, licensed under the MIT License (MIT)
+# This file is a part of MonotonicSplines.jl, licensed under the MIT License (MIT)
 
 
 # Non-public:

diff --git a/test/test_rqspline.jl b/test/test_rqspline.jl
@@ -105,8 +105,7 @@ for compute_unit in compute_units
         YM = fM(XM)
         @test @inferred(broadcast(inv_f, Y)) == vec(@inferred(inv_fM(YM)))
 
-        # See issue #17:
-        @test_broken inv_f.(Y) ≈ X
+        @test inv_f.(Y) ≈ X
 
         Y_ladj = @inferred(broadcast(with_logabsdet_jacobian, f, X))
         YM_ladj = @inferred(with_logabsdet_jacobian(fM, XM))